Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dataViews] dedupe data view loading toasts #131779

Merged
merged 11 commits into from
May 18, 2022
Merged

[dataViews] dedupe data view loading toasts #131779

merged 11 commits into from
May 18, 2022

Conversation

mattkime
Copy link
Contributor

@mattkime mattkime commented May 8, 2022 •
edited
Loading

Summary

Dedupe data view loading toast errors.

This issue shows an example - #67270 - that said, I don't think this specific example is possible anymore due to optimizations in loading data views.

I did find a case that would create a duplicate error -

  1. Load sample data
  2. Close index for sample data
  3. Go to discover. On main you'll see two toasts, on this branch you'll see one.

@mattkime mattkime changed the title debounce data view toasts [dataViews] dedupe data view loading toasts May 8, 2022
@mattkime mattkime mentioned this pull request May 11, 2022
Merged
@mattkime mattkime added v8.3.0 Feature:Data Views Data Views code and UI - index patterns before 8.0 Team:AppServicesSv release_note:skip Skip the PR/issue when compiling release notes labels May 16, 2022
@mattkime mattkime marked this pull request as ready for review May 16, 2022 04:01
@mattkime mattkime requested a review from a team as a code owner May 16, 2022 04:01
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesSv)

@mattkime mattkime requested a review from shivindera May 16, 2022 04:02
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
dataViews 46 47 +1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
data 2861 2863 +2
dataViews 710 712 +2
total +4

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
dataViews 39.7KB 40.0KB +286.0B
Unknown metric groups

API count

id before after diff
data 3473 3475 +2
dataViews 862 864 +2
total +4

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mattkime mattkime merged commit 0f3af54 into elastic:main May 18, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shivindera shivindera shivindera approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Data Views Data Views code and UI - index patterns before 8.0 release_note:skip Skip the PR/issue when compiling release notes v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mattkime @elasticmachine @kibana-ci @shivindera @kibanamachine